Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.12: SyntaxWarning: invalid escape sequence '\s' (closes #1312) #1313

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix Python 3.12: SyntaxWarning: invalid escape sequence '\s' (closes #1312) #1313

merged 2 commits into from
Oct 8, 2024

Conversation

u1735067
Copy link
Contributor

@u1735067 u1735067 commented Jun 3, 2024

This fixes #1312 (Python 3.12: SyntaxWarning: invalid escape sequence '\s' (tty.py:55)) by using the Python raw string syntax where \ are not evaluated.

@u1735067
Copy link
Contributor Author

u1735067 commented Jul 1, 2024

I don't think the following error is related to my change, maybe a dependency?

======================================================================
ERROR: test_device_facts (tests.unit.test_device.TestDevice)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/unittest/mock.py", line 1336, in patched
    return func(*newargs, **newkeywargs)
  File "/home/runner/work/py-junos-eznc/py-junos-eznc/tests/unit/test_device.py", line 526, in test_device_facts
    assert self.dev.facts["version"] == facts["version"]
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/jnpr/junos/factcache.py", line 119, in __getitem__
    raise RuntimeError(
RuntimeError: The jnpr.junos.facts.get_software_information module returned the model fact, but does not list model as a provided fact. Please report this error.

But if so, I'm not familiar enough with the codebase to understand why, sorry.

dineshbaburam91
dineshbaburam91 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@dineshbaburam91 dineshbaburam91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dineshbaburam91 dineshbaburam91 merged commit 02c7d02 into Juniper:master Oct 8, 2024
@dineshbaburam91 dineshbaburam91 mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshbaburam91 dineshbaburam91 dineshbaburam91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.12: SyntaxWarning: invalid escape sequence '\s' (tty.py:55)
2 participants
@u1735067 @dineshbaburam91